Skip to content

Restrict importing src/lib in most cases for matrix- libs#3575

Merged
toger5 merged 1 commit intolivekitfrom
hs/lint-src-imports
Nov 20, 2025
Merged

Restrict importing src/lib in most cases for matrix- libs#3575
toger5 merged 1 commit intolivekitfrom
hs/lint-src-imports

Conversation

@Half-Shot
Copy link
Copy Markdown
Member

Based off @BillCarsonFr 's struggles, we can use the linter to prevent us importing /paths, which is usually a bad smell.

@Half-Shot Half-Shot requested a review from a team as a code owner November 20, 2025 13:33
@Half-Shot Half-Shot requested a review from AndrewFerr November 20, 2025 13:33
@Half-Shot Half-Shot added T-Task Refactoring, enabling or disabling functionality, other engineering tasks PR-Task Release note category. A PR that is hidden from release note. PR-Developer-Experience Release note category. A PR that does not change EC but improves working with the repository. and removed T-Task Refactoring, enabling or disabling functionality, other engineering tasks PR-Task Release note category. A PR that is hidden from release note. labels Nov 20, 2025
Copy link
Copy Markdown
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works perfectly, thx

Copy link
Copy Markdown
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@toger5 toger5 merged commit f6ef872 into livekit Nov 20, 2025
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Developer-Experience Release note category. A PR that does not change EC but improves working with the repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants